Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Results summary component solution using flexbox

Xqu1shyβ€’ 270

@Xqu1shy

Desktop design screenshot for the Results summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Please criticize my solution and give me any feedback

Community feedback

P
visualdennisβ€’ 8,375

@visualdenniss

Posted

Good work there! Final result looks nice overall, especially on desktop size.

I'd suggest avoid giving fixed height or max-heights for elements/containers that contain text elements. It will cause accessibility issue, when user changes their default font-size, text will overflow and break the layout. (e.g. you used height:550 for .container) but also fixed height of 100vh for the body. I'd suggest replacing that with min-height: 100vh instead, so it is never smaller but can expand when needed. Body 100vw is also unnecessary as it is the default.

In tablet layout, there seems to be some issues with columns appear on the left side of the page and there is big space on the right. Instead of giving width: 780px you can give a max-width. Same for the invidual columns like .result

Hope you find this feedback helpful!

Marked as helpful

0
Abdul Khaliq πŸš€β€’ 72,660

@0xabdulkhaliq

Posted

Hello there πŸ‘‹. Congratulations on successfully completing the challenge! πŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage
  • So fix it by replacing the <div class="container"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.
  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>
  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

.

I hope you find this helpful πŸ˜„ Above all, the solution you submitted is great !

Happy coding!

1
GlitzDevβ€’ 50

@GlitzDev

Posted

nice one ! just pay atention on colors guide in styles.md...

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord