@yefreescoding
Posted
Perfect, now I can see what you've done 😁.
You did a pretty good job, and I really like how you build and organize your HTML file.
- One tip is that you should use more semantic HTML tags for your components, such as
<main>
,<section>
,<header>
,<footer>
, etc. There are semantic HTML tags for almost any use case. Remember that<div>
means division and shouldn't be used for everything.
Your styles are great as well, just a couple of things:
- The
<div class="your-result column-1">
does not have theborder-radius: 20px
; you applied it to the parent container<div class="flex-box"/>
. Take a look at the original design, and you will see how the border is curved on the left side.
The last thing I've noticed is your table on the left side, where you decided to put the data:
- Use these properties:
display: flex;
,flex-direction: column;
, andgap: 16px;
. These will help you control the components inside your<tbody>
element using flex. - You can also use the same property,
display: flex;
, on the<tr class="reaction-background"/>
elements. The flex property, combined withjustify-content: space-between;
, can fix the position of the data inside the<tr class="reaction-background"/>
.
Overall, you're doing a great job so far. Keep practicing; you're on the right path. I hope this helps you improve. If you need anything, feel free to ask me.
Marked as helpful