Submitted about 1 year ago
Results summary component solution
@kerdaino
Design comparison
SolutionDesign
Solution retrospective
Check out my codes and kindly suggest a more efficient ways feedbacks are highly welcome
Community feedback
- @MelvinAguilarPosted about 1 year ago
Hello there 👋. Good job on completing the challenge !
I have some small suggestions about your code that might interest you.
- The <div> tag can be useful for styling and positioning, but it doesn't convey any semantic meaning. Also, the purpose of a
<span>
element is to apply styles to a specific piece of content within a larger block of text, without adding any semantic meaning. Instead, consider using more semantic elements like <p> to better describe the type of content.
- For icons, you should still use the alt attribute, but it should be empty (
alt=""
). This indicates to screen readers and other assistive technologies that the icon is decorative and that they should skip over it
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
Marked as helpful0@kerdainoPosted about 1 year agothank you i find the suggestions very helpful and will make necessary adjustment@MelvinAguilar
0 - The <div> tag can be useful for styling and positioning, but it doesn't convey any semantic meaning. Also, the purpose of a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord