Results summary component solution

Community feedback

• 

  Maykol Vallejos•200

  @maykol-vallejosPosted over 1 year ago

  Hi, how are you? I was reviewing your code and I saw a very good code structure, readable for changes and with a very good development logic.

  I had a small observation to make regarding accessibility, try not to use "px", it is a bad practice for future projects, maybe now is not a very strong error in this that you developed but in future projects can affect you a lot, and it is not your fault, is that each browser handles its own settings, especially the font settings .., (If you like you can corroborate it on a 768px screen and you will see that there is a brief resizing failure of your project created. )

  So a good practice for it is to use the 62.5% font size technique, you can check the following article to learn about it and apply it for a more efficient work:

  https://www.aleksandrhovhannisyan.com/blog/62-5-percent-font-size-trick/

  So you don't worry about making changes if changes are made in the browser. I hope this advice is useful for you. Keep up the good work. Success in future coding! Best regards! ;)

  Marked as helpful

  0

  ---

  

  Valentina López•190

  @valentinalopezh98Posted over 1 year ago

  @maykol-vallejos Thanks, that's very helpful! :)

  0
• 

  Romanarabe•20

  @RomanarabePosted over 1 year ago

  beautiful :)

  1