Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Results Summary Component (React and SASS)

Scott Ning 170

@ning-sy210

Desktop design screenshot for the Results summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I would like to ask for feedback and best practices in the following areas:

  • Project Folder Structure

Reason for using the project structure that I have is because I want to keep things modular, this allows the component to be plug-and-play and it can be reused in another project if need to, and all that needs to be done is to simply copy the entire folder over. But of course, doing so will mean that there will be a lot of folders containing a small number of files, and this might not be appropriate for a project at scale.

  • Architecture of the Component

I'm looking for comments on what can be done to structure the component and its child components better. What I've done is I have broken up the component into many smaller components because I feel there are a number of benefits to keeping the file size small (ideally <100 lines implementation-wise):

  1. Reduces the contextual text volume that another person has to process if he/she is a collaborator or is taking over the project and need to make some changes (beneficial to peers)
  2. Easier for code reviews in a collaborative setting (beneficial to managers)

Any other comments are also welcome! For example, what can be done better for the choice of CSS structure or naming convention (used BEM for this project but I don't know if it's correctly used), just to name a few examples.

Community feedback

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord