Results summary component

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted over 1 year ago

  Html looks good to me except you should never have text in a div/span alone. So I’d wrap that score bit in a paragraph instead of div.

  Well done

  0

  ---

  

  T

  Grace•31,270

  @grace-snowPosted over 1 year ago

  A couple of accessibility issues on this

  1. You have font-size: 18px; in the css. You need to convert that to rem so that user font sizes can be honoured. It’s extremely important to never use px for font sizing

  2. Similar, write media query declarations with rem/em so they scale with user font size settings too.

  Marked as helpful

  0