Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Results summary component - mobile and desktop view

Mateusz 150

@matsta92

Desktop design screenshot for the Results summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi, I am a complete beginner in such practical projects. I had previous contact with html and css by learning topics and solving sentences in a specific topic. I have no experience with such projects.

Please rate this project :)

Community feedback

P
beowulf1958 1,170

@beowulf1958

Posted

Project looks great. A few suggestions: first, when you submit a project, it is helpful if you use a few tags such as #mobile-first, #sass, etc. This allows others to quickly find the projects they want to review.

Second, you might want to keep it DRY (don't repeat yourself). There are several places where you styled an element font-weight:bold; you could just leave that out and add the bold class to the elements that need it (I noticed you had created a .bold utility class and never used it.) So

<p class="summary-title bold">Summary</p>

You could also move text-align:center; color:hsl(0, 0%, 100%); to the style for .your-result and let the inheritance do its job, saving a few lines of code. You might want to check out shorthand properties for margin and padding. Several places you use the long hand for margin, --> .results-points-box {margin: 16px 0 16px 0;} is the same as {margin: 16px 0;} saving yourself a few keystrokes.

Hope this helps!

Marked as helpful

0

Mateusz 150

@matsta92

Posted

@beowulf1958 Thank You for comment :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord