Results Summary Component Main

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  .

  CSS 🎨:

  • Use min-height: 100vh instead of height: 100vh;, to properly center the component both horizontally and vertically

  ---

  • Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation

  ---

  • min-height says that the minimum height is some value but that the element can continue to grow past that defined height if needed (like the content inside makes it taller or whatever).

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  Rebecca Copeland•50

  @rebcopPosted over 1 year ago

  Hi! Looking good!

  Just a few things:

  • Update the "README-template" file. Remove the old "README" file and rename "README-template" to "README"
  • Looks like you did get it be responsive. I can see it on the mobile version through Developer Tools and when making the window width smaller so not sure what you're asking. Though in the mobile version, the component is not covering the full width.
  • Stay consistent with one type of unit. I've been informed typically em/rem is best instead of px which is a fixed unit

  Marked as helpful

  0