@AGutierrezR
Posted
Hello there 👋. Good job on completing the challenge!
I have some suggestions about your code that might interest you.
HTML:
- You could replace the
.text
and.numbs
paragraphs with<span>
tags. This could be more semantic because is not a paragraph per se. - Try not to use the
<main>
tag as a component, use it as a container that will wrap the component in question.
CSS:
- Try not set a fixed width, use
max-width
instead (style.scss
line10
). If you want to limit set a minimum width you could do that also. - Let the content define the
height
of the.your-result
element, you could use padding and margins for the children to achieve this. And of course, the.your-result
padding is a must.
Marked as helpful