Results Summary Component Main

Community feedback

• 

  Clinto Bean•130

  @clinto-beanPosted over 1 year ago

  Hey Matthew, great job on this. It's very responsive on both my laptop and mobile. Your layout is almost 100% perfect - it seems there's some padding on yours that makes it slightly smaller than the original design but other than that it is 100%.

  The only improvement to the code I can see in your App.jsx is that there are some cases where the classname is written in camel case with the first word capitalized, while there are others where it is not. For example:

  className="CardRightContainer" and className="containerCardRight", typically the tradition in JS is that you would not capitalize the first word, but if you wish to do so it may look better to do it on all of them.

  Another thing you can look to is to create a component for each of the score bars which would map over each category to create the bar, this would make it easier to add or remove rows if a new category were added or removed.

  Great work!

  0