Results summary component main. Pug, Sass, vanilla JS

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  COMPONENT MEASUREMENTS 📐:

  • The width: 100vw property for #container element is not necessary. because it's a block level element which will take the full width of the page by default.

  ---

  • Use min-height: 100vh for #container instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the #container will have 100vh height no matter what. Even if the content spans more than 100vh.

  ---

  • But if we set min-height: 100vh then the #container will start at 100vh, if the content pushes the #container beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Alex•20

  @GoodAlex223Posted over 1 year ago

  @0xAbdulKhalid , thank you for the great advice and explanations. Already applied to my solution and recorded for future projects)

  0