Abdul Khaliq πβ’ 72,660
@0xabdulkhaliq
Posted
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
COMPONENT MEASUREMENTS π:
- The
width: 100vw
property for#container
element is not necessary. because it's a block level element which will take the full width of the page by default.
- Use
min-height: 100vh
for#container
instead ofheight: 100vh
. Setting theheight: 100vh
may result in the component being cut off on smaller screens.
- For example; if we set
height: 100vh
then the#container
will have100vh
height no matter what. Even if the content spans more than100vh
.
- But if we set
min-height: 100vh
then the#container
will start at100vh
, if the content pushes the#container
beyond100vh
it will continue growing. However if you have content that takes less than100vh
it will still take100vh
in space.
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful
1
Alexβ’ 20
@GoodAlex223
Posted
@0xAbdulKhalid , thank you for the great advice and explanations. Already applied to my solution and recorded for future projects)
0