Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Results summary component main. Pug, Sass, vanilla JS

Alexβ€’ 20

@GoodAlex223

Desktop design screenshot for the Results summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


  • Mobile first
  • Grid, flex layouts
  • Pug, Sass preprocessors
  • Responsive web design

What is the first thing that catches your eye that could be improved? Thanks for the answers.

Community feedback

Abdul Khaliq πŸš€β€’ 72,660

@0xabdulkhaliq

Posted

Hello there πŸ‘‹. Congratulations on successfully completing the challenge! πŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

COMPONENT MEASUREMENTS πŸ“:

  • The width: 100vw property for #container element is not necessary. because it's a block level element which will take the full width of the page by default.
  • Use min-height: 100vh for #container instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.
  • For example; if we set height: 100vh then the #container will have 100vh height no matter what. Even if the content spans more than 100vh.
  • But if we set min-height: 100vh then the #container will start at 100vh, if the content pushes the #container beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

.

I hope you find this helpful πŸ˜„ Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

1

Alexβ€’ 20

@GoodAlex223

Posted

@0xAbdulKhalid , thank you for the great advice and explanations. Already applied to my solution and recorded for future projects)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord