@Sachin-Mahato
Posted
Well done for finishing the challenge.
As a front-end developer, your primary task is to transform the designer's visual concept into a functional website. The objective is to ensure that the final website closely resembles the original design. However, if there are noticeable differences between the website and the intended design, it's important to address this issue.Use the build-in frontend Mentor design comparison tool.
1. Lack of semantic HTML:
- Semantic HTML elements are missing or not used appropriately.
- The structure does not convey the meaning and purpose of different parts of the webpage.
-.Every site should ALWAYS have ✅ a main element not only for semantic purposes but also to help assistive technology find the main content of your content. For this challenge, it will serve as the component’s container ⚠️.
--
.Usage of absolute units instead of relative units:
- Absolute units like pixels (
px
) are used for defining lengths and sizes instead of relative units like percentages (%
),em
, orrem
. - Relative units are more flexible and responsive across different screen sizes.
Your CSS Reset is being underutilized. 😢 To fully maximize 💯 it, you will want to add more to it. Here are some examples that you can freely use 😁: Josh Comeau Reset Eric Meyer Reset
For improved accessibility 📈 for your content, it is best practice to use em ✅ for media queries. Using this unit gives users the ability to scale elements up and down, relative to a set value use this link to learn about media queries
I hope you find this helpful and happy coding.
Marked as helpful