Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

results summary component made with React and flexbox

@TomasPereira-Dev

Desktop design screenshot for the Results summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


-questions

1.Are the font sizes from the titles in the components correctly?.

2.There is a h2 that says "Great", it shouldn't be there, how can you make something similar with p tags? (tried with more font-size and weight but it didn't look quite right.

Community feedback

P
Fluffy Kas 7,735

@FluffyKas

Posted

Heyo,

Your solution looks really good, sseems pretty close to the original.

Not sure I understand correctly what you're asking here though? You could change change the font-size of your h2. I wouldn't use strong tags ( I noticed you're using them everywhere but I don't think it's very necessary or semantic), you could just set a font-weight on them (I can see that you're importing multiple ones so it shouldn't be a problem).

Another thing: imgs are self closing tags: <img />. Also, I see your images are broken at the moment. In React if you'd like to use an image, you cannot really do that in the regular way (pointing to a relative path in the img src) like you'd do it in a html file, it won't work. You can import your images one by one, like this:

import checkmark from '../../assets/images/icon-checkmark.svg';

const Results = () => {
return (
<main>
//some other code...
<img src={checkmark} alt="" />
</main>
);
};

export default Results;

Not sure how much experience you have, but as @itush said, it's nice to have a solid understanding of the fundamentals before you jump on to React. This project doesn't really call for a framework, it's just making your life harder here. That being said, good job again, the end result is something you should be proud of ^^

Marked as helpful

1

Tushar Biswas 4,080

@itush

Posted

@FluffyKas

Couldn't agree more, starting the fronted development journey without a solid grasp of the fundamental is very risky.

0
Tushar Biswas 4,080

@itush

Posted

Congratulations on completing the challenge! 🎉

Welcome to the platform! 🎉 We're thrilled to have you here and excited to see your progress 💪as you continue your front-end development journey.

Your solution looks nice to me :)

  • It'd look even nicer if you apply some margin around the main-container for smaller screens.
  • The svg icons are not visible on the page, you may need to fix the path.
  • You can follow the style guide to apply the font/color for an element, and if that does not look right you may adjust it accordingly.

In my projects:

  • I always start with mobile-first workflow.
  • I use at least one main element for a page (entire content goes into the main, if I'm not using header & footer), and avoid divs as much as possible and use section and article element wherever I can.
<body>
<main>
All content 
</main>
</body>
  • I Use relative units as much as possible and avoid absolute units whenever possible.

  • If you are someone who is just starting out with front-end development, I strongly suggest starting with the QR code component project. Also in the challenges page you may filter by (Newbie, HTML&CSS) sort by (easier first) to select projects that will help you solidify your foundation. To avoid any potential knowledge gap⚠️ please first solidify HTML, CSS, JS fundamentals and then move on to any framework or library.

  • I remember when I started out, I made countless mistakes and spent long hours searching for solutions. But hey, you don't need to go through the same struggles! 🙌 To help you shorten the learning curve, I recommend going through the following articles. They contain valuable insights that can make your journey smoother:

📚🔍 12 important CSS topics where I discuss about css position, z-index, box-model, flexbox, grid, media queries, mobile-first workflow, best practices etc. in a simple way.

📚🔍 11 important HTML topics where I discuss about my thought process and approach to convert a design/mock-up to HTML along with other topics.

I hope you find these resources helpful in your coding adventures! 🤞

I'm eagerly looking forward to seeing the amazing projects you'll create in the future! 🚀💻

Keep up the fantastic work and happy hacking! 💪✨

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord