Design comparison
Solution retrospective
I would like to know if the amount of divs I used for the project is adequate or not, or any other comments for improvement are welcome. Thanks :)
Community feedback
- @danielmrz-devPosted 10 months ago
Hello Jose!
Your solution looks excellent!
I have a couple of suggestions:
- First: Use
main
to wrap the main content instead ofarticle
.
π The tag
article
would make more sense if the card was part of a bigger website (in certainly would in real world), but here it is all we have on the screen.- Second: - Don't skip heading levels - start with
<h1>
, then use<h2>
, and so on. Unlike what most people think, it's not just about the size and weight of the text.
π The
<h1>
to<h6>
tags are used to define HTML headings.π
<h1>
defines the most important heading.π
<h6>
defines the least important heading.π Only use one
<h1>
per page - this should represent the main heading/title for the whole page.Those tag changes have little or not effect at all on the project, but they make your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful0 - First: Use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord