Results summary component - HTML CSS

Community feedback

• 

  Bryan Li•3,530

  @Zy8712Posted 12 months ago

  Hi Jim! Your site looks great! Some suggestions I have for you are:

  • using a <main> tags to wrap around the main contents of your page, this is for accessibility purposes
  • using header tags such as <h1> and <h2>, for titles such as !Your Results" and "Summary". This is also for accesibility purposes as well as screen readers will scan for these types of tags and treat them differently as opposed to text just in <div> tags or <p> tags

  Hope you find this feedback useful!

  Marked as helpful

  1

  ---

  

  JimTK16•370

  @JimTK16Posted 12 months ago

  @Zy8712 Hi, thanks for the feedback. I have updated my code per your suggestions.

  Cheers

  0
• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 12 months ago

  Hello, Jim!

  Your project looks nice!

  I have one suggestion:

  • On the desktop version, you can place your card in the middle of the page doing this:

  body {
     height: 100vh;
     display: flex;
     align-items: center;
     justify-content: center;
  }
  

  I hope it helps!

  Other than that! It looks great!

  Marked as helpful

  1

  ---

  

  JimTK16•370

  @JimTK16Posted 12 months ago

  @danielmrz-dev thanks Daniel

  1