Abdul Khaliq πβ’ 72,660
@0xabdulkhaliq
Posted
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML π·οΈ:
- Your solution generates accessibility error reports due to
non-semantic
markup
- So fix it by replacing the
<div id="root">
with semantic element<main>
to improve accessibility and organization of your page.
CSS π¨:
- As per the design we want to center the component
.component
both horizontally & vertically with css
- To properly center the component in the page, you should use
Flexbox
orGrid
layout. You can read more about centering in CSS here π.
- For this demonstration we use css
grid
to center the component
body {
min-height: 100vh;
display: grid;
place-items: center;
margin: 0;
}
I hope you find it helpful ! π Above all, the solution you submitted is great!
Happy coding!
0