Design comparison
Solution retrospective
I am not good at English, so I will use it as a translator. I am a beginner Korean who is new to the front end. Please advise me if you have any regrets or need to fix after looking at the code.
Community feedback
- @hitmorecodePosted about 1 year ago
Good effort. I took a look at your page and there is a lot of things to change. I'll try to keep short and explain what to fix.
- You used
position
on many elements, try to avoid this. When using position it will make it harder to create a responsive page. There are better ways to this, you could used css grid or flexbox. If you are not familiar with css grid or flexbox, take your time to learn these two concepts. - You used
id="infoMenu"
on six elements. You cannot do this, an id can only occur one time. You cannot have two or more elements with the sameid
. If you want to use id, each element must have it's ownid
. If you want to repeat it's best to useclass
,class
has no limitations on the number of elements. - In this case you don't need to use
<br>
to separate the lines. Inside css you could have styled the width of the<p>
element, this will force the text to jump to the next line.
<p class="intro_P5"> You scored higher than 65% of<br> the people who have taken<br> these tests. </p>
- You used
<strong>
to highlight the number80
. You could have done this with a<span>
element and inside css style the<span>
element.<p id="RP2" class="reactionP"><strong>80</strong> / 100</p>
/* you could have done this */ <p id="RP2" class="reactionP"><span>80</span> / 100</p>
If you want to learn css grid here is a Korean tutorial. I don't speak Korean so I don't know if the tutorial is good.
You can also search for Korean tutorials on flexbox.
Keep coding 👍 😎 and I you need any help let me know.
Marked as helpful0@RangCloudPosted about 1 year agoThank you very much for your advice. I will study hard and make it perfect. Thank you very much.
0@hitmorecodePosted about 1 year ago@RangCloud I was glad I could help. If you get stuck and need help, don't hesitate to ask 👍
0 - You used
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord