Submitted 11 months ago
Results Summary Component challenge solution using HTML & CSS
@itzvikashgupta
Design comparison
SolutionDesign
Solution retrospective
Any suggestions on how I can improve are welcome!
Community feedback
- @danielmrz-devPosted 11 months ago
Hello @itzvikashgupta!
Your solution looks great!
I have a couple of suggestions:
- Since you set grid to the body, but you didn't set the size of the rows, your footer is pushing your card up a little bit. You can prevent that from happening adding this to the body:
grid-template-rows: 90% 1fr;
Then your card will always occupy 90% of the space and the footer will adapt in the remaining space.
I hope it helps!
Other than that, you did an excellent job!
Marked as helpful1@itzvikashguptaPosted 10 months agoAh! I see, I was wondering why this was happening, now I get it. Thanks man! It was definitely a great help. @danielmrz-dev
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord