Results summary component challenge responsive solution

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have some recommendations regarding your code that I believe will be of great interest to you.

  HTML 🏷️:

  • This solution generates accessibility error reports due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the <div class="container-full"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  harigsr1998•30

  @harigsr1998Posted over 1 year ago

  @0xAbdulKhalid Thanks for the feedback. I am interested and it is helpful. I just haven't yet gotten to learning about semantic elements (that name itself is new to me😅). Will try to update these solutions once I've learnt those. TYSM for the feedback😁👍👍👍

  0
• 

  K.Damsith•330

  @DamsithcoderPosted over 1 year ago

  GREAT job .well done . if you use the main tag for the first div in your html code ,some issues might disappear in your code

  <div class="container-full"> to <main> keep coding

  Marked as helpful

  1

  ---

  

  harigsr1998•30

  @harigsr1998Posted over 1 year ago

  @Damsithcoder Thank you for the info. I have read about <main> tag and such but haven't gotten to learning about it yet. TYSM for the feedback😁👍👍👍

  0