@0xabdulkhaliq
Posted
Hello there π. Congratulations on successfully completing the challenge! π
- I have some recommendations regarding your code that I believe will be of great interest to you.
HTML π·οΈ:
- This solution generates accessibility error reports due to
non-semantic
markup, which lack landmark for a webpage
- So fix it by replacing the
<div class="container-full">
element with the semantic element<main>
in yourindex.html
file to improve accessibility and organization of your page.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>
or<span>
- They convey the structure of your page. For example, the
<main>
element should include all content directly related to the page's main idea, so there should only be one per page
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful
@harigsr1998
Posted
@0xAbdulKhalid Thanks for the feedback. I am interested and it is helpful. I just haven't yet gotten to learning about semantic elements (that name itself is new to meπ ). Will try to update these solutions once I've learnt those. TYSM for the feedbackππππ