Design comparison
Solution retrospective
I'm having difficulty spotting an issue in my code where the div class for the summary scores are not lining up on one line. It may be the same issue causing the icons not to show up and the alt text to show up instead. If there is any assistance you can give me, I'd greatly appreciate it.
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML π·οΈ:
- This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>
or<span>
. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers
- For example:
- The
<main>
element should include all content directly related to the page's main idea, so there should only be one per page - The
<footer>
typically contains information about the author of the section, copyright data or links to related documents.
- So resolve the issue by wrapping the first two
<div>
elements with the semantic element<main>
along with<div class="attribution">
into a<footer>
element in yourindex.html
file to improve accessibility and organization of your page
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0@katrina-l-hillPosted over 1 year ago@0xAbdulKhalid Thank you!!! I really appreciate your help. I made the changes you recommended.
0 - @MattologicalPosted over 1 year ago
nest both div elements inside an outer div container and go to CSS and use a float property of left
in html -- <div class="container"> </> in CSS .container{ float: left; } hope this solves it
Marked as helpful0@katrina-l-hillPosted over 1 year ago@Mattological Thanks so much for your help. This worked and was very helpful!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord