Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Results Summary Component

@ViniCellist

Desktop design screenshot for the Results summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feedback on this one pls

Community feedback

Hassan Moataz 1,860

@hassanmoaa

Posted

Hello @ViniCellist!

Great Job solving the challenge mate *congrats * 🎉

Some suggestions for improvements.

Heading is defined with <h1> to <h6> tags. It is important to use headings to show the HTML document structure.

<h1> headings should be used for main headings, followed by <h2> headings, then <h3>, and so on up to <h6>

➖➖➖➖

  • Consider increasing the width of the container also!

Other than that you're good, keep up the good work!

Marked as helpful

1
Daniel 🛸 44,230

@danielmrz-dev

Posted

Fala @ViniCellist!

Seu projeto ficou muito bom!

Uma dica:

  • Evite usar valores baseados no tamanho da viewport (vh e vw) pra configurar a largura ou altura de elementos. Parece que ajuda na responsividade, mas na verdade não ajuda.

Uma alternativa pra manter a adaptabilidade do elemento é configurar uma largura máxima pro elemento com max-width e um valor em pixels ou rem. Dessa forma, o elemento continua responsivo, mas só cresce até determinado ponto.

Pra altura, nem precisa configurar valor nenhum, só basta colocar os elementos filhos dentro que o elemento pai se adapta pra fazer caber tudo dentro dele.

Espero que ajude! 😊

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord