Design comparison
Solution retrospective
I tried using the fonts provided in the starter files but couldn't successfully implement them. As an alternative, I imported fonts from Google Fonts. Another challenge I face is that since I only have free access, it becomes difficult to determine the exact values for font size, margin, and other properties.
Community feedback
- @Ozzy-codesPosted over 1 year ago
Hi ggsuha, Congrats on completing this project!
Sharing some suggestions to consider!
I forked your repo and sent over a PR to address the footer laying on top of your summary card when examining your site on mobile view (375px width). You can see a screenshot of the issue on the PR . Suggested code was written to retain your use of the grid property. Forked repo - branch: adjust_crowding_grid_solution
TL:DR - I've moved properties set on main one level up onto body
Sizing elements:
I recently got some feedback on the use of px’s in sizing elements and accessibility considerations and wish to share the same with you! It's generally recommended to avoid using px for sizing elements which can affect website responsiveness and accessibility. Why designers should move from px to rem...
Marked as helpful0@ggsuhaPosted over 1 year ago@Ozzy-codes Hey, thanks for the feedback. I have merged the fork.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord