@BenjaminSemah
Posted
Hello Saul. Great job done! 👍
HTML: Your HTML is well structured and easy to read. I think what you can do to improve it is to use semantic HTML elements.
You use divs almost throughout. That works technically. But for the sake of improving accessibility and SEO, I will encourage you to consider using semantic elements like main, section, footer, and ul/li elements for lists.
CSS: For your CSS, you declare variables for the colors (which I think was excellent.) But going through your code, I realise you didn’t use the variables where you could have. For example, for your linear-gradients. You could have used the variables you declared instead of hardcoding the color values.
As your code is now, if you wanted to change the colors for the gradient, you would have to change them one by one. But if you had used the variables you declared, then when you want to change the colors, you wouldn’t need to change them one by one. But you only have to change the value of the variable and the change will apply to all places where the variable is used.
I hope this helps. Best wishes and happy coding!
Marked as helpful
@Saul-Gustavo
Posted
@BenjaminSemah Thank you very much, this project is quite complicated for me when I write in code, I will modify it, thank you very much for your contribution.
