Results Summary Component

Community feedback

• 

  Bibiwei Pere•490

  @Bibiwei-PerePosted almost 2 years ago

  Hi @Whitney

  Nice work! But i noticed that your project is not responsive. Use the appropriate media query to make it more responsive.

  0

  ---

  

  Whitney Dallas•80

  @Wdallas12Posted almost 2 years ago

  @Bibiwei-Pere I added the one media query for the dimensions outlined in the instructions, so there is a mobile and desktop version. Is there another one that I should add?

  0

  

  Bibiwei Pere•490

  @Bibiwei-PerePosted almost 2 years ago

  @Wdallas12

  The instructions were Desktop 1440px and Mobile 375px. But you used (min-width:1400px). That's to much for a mobile design.

  Thanks

  0

  

  Whitney Dallas•80

  @Wdallas12Posted almost 2 years ago

  Ah that's because I decided to go with a mobile-first design process this time. So I did the main body CSS with mobile design in mind and then made the media query the desktop adjustments.

  Although to be honest I'm not sure if that's what is meant by mobile-first design. I think I need to do some research on it.

  @Bibiwei-Pere

  0

  

  Bibiwei Pere•490

  @Bibiwei-PerePosted almost 2 years ago

  @Wdallas12 Okay, I now understand what you were trying to do.

  0
• 

  Mukwende•1,370

  @mukwende2000Posted almost 2 years ago

  what do you want javascript for, there is no need for it in this challenge

  0

  ---

  

  Q8LPs6Vs•100

  @Q8LPs6VsPosted almost 2 years ago

  @mukwende2000

  She wants to render the test results from the provided JSON file, which is an optional task given in the challenge description.

  1