Design comparison
SolutionDesign
Community feedback
- @thomashertogPosted over 1 year ago
Your solution is looking good visually! There are some few improvements to be made though.
HTML/accessibility
- you used a
<main>
element which is good, however you also used<div class="paragraph">
while there is a<p>
element exactly for paragraph text - the results themselves (the elements with
class="record"
in your code should be a list
CSS
- use
min-height
instead ofheight
to ensure overflow issues are not caused when content is expanding - try working with
em/rem
instead ofpx
Marked as helpful0 - you used a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord