Results summary component

Community feedback

• 

  Samdevtechnology•130

  @SamdevtechnologyPosted over 1 year ago

  Hello there 👋. Congratulations on a job well done! 🎉 🎉 🎉

  • I would like to make some suggestions concerning your code that might be of help.

  HTML 🏷️:

  • This solution generates accessibility error report: "All page content should be contained by landmarks". This is due to a non-semantic markup, which causes a lack of landmark for a webpage.

  • So fix this by replacing the <div class="wrapper"> element with the semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file.

  • What is meant by landmark ?: They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers. We make use of sematic elements to provide landmarks to our webpage example includes <main>, <aside>, <footer>, etc., instead of relying on generic elements like <div> or <span>.

  Recommendation

  • Instead of leaving this link empty <a href="">Zabol</a>. Why not link to your favorite social media handle or to your frontend mentor profile page.

  Well done for completing this challenge 👍

  I hope have been of help, Please feel free to ask any question

  Happy Coding 🎉

  Marked as helpful

  0