Design comparison
Solution retrospective
Is it good approach to get styles for colours and different font weight? How to simplify main CSS? I think there is a big mess Is it good to use variables in this project? If yes where? For colours?
Community feedback
- @Kamlesh0007Posted over 1 year ago
yes using variables for colors and font weights can indeed be a good approach to simplify the main CSS and improve maintainability in a project. By defining variables for these values, you can easily update them in one place, which ensures consistency and makes it easier to manage and modify styles throughout your codebase.
Marked as helpful0 - @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
DECORATIVE SVG'S β¨οΈ:
- The
alt
attribute is used to provide alternative text for images in HTML documents. Thealt
attribute is used by screen readers to describe the image to visually impaired users, which is essential for web accessibility.
- Now, when it comes to decorative
SVGs
, they are used purely for aesthetic purposes and do not convey any important information or functionality to the user.
- Since these images do not convey any important information or functionality, there is no need for an
alt
attribute.
- So feel free to set the
alt
attribute as""
for decorativesvg's
, becausealt=""
will be skipped by screen readers they will consider the image as decoration
Example:
<img src="images/decorative.svg" alt="">
<img src="./assets/images/icon-reaction.svg" alt="reaction"> π <img src="./assets/images/icon-reaction.svg" alt="">
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord