Results summary component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  DECORATIVE SVG'S ♨️:

  • The alt attribute is used to provide alternative text for images in HTML documents. The alt attribute is used by screen readers to describe the image to visually impaired users, which is essential for web accessibility.

  ---

  • Now, when it comes to decorative SVGs, they are used purely for aesthetic purposes and do not convey any important information or functionality to the user.

  ---

  • Since these images do not convey any important information or functionality, there is no need for an alt attribute.

  ---

  • So feel free to set the alt attribute as "" for decorative svg's, because alt="" will be skipped by screen readers they will consider the image as decoration

  ---

  Example:

  <img src="images/decorative.svg" alt="">
  
  

  <img src="assets/images/icon-reaction.svg" alt="reaction">
  👇
  <img src="assets/images/icon-reaction.svg" alt="">
  
  

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  Saad Hisham•1,750

  @Saad-HishamPosted over 1 year ago

  Hello there! 👋😀

  I just wanted to say that you did an amazing job on your challenge! Your project looks great, and I'm impressed with your skills. I do have a couple of tips that I think could make it even better.

  Firstly, for better accessibility, it would be a good idea to wrap the card in a main tag instead of a div tag. This helps to provide more semantic meaning to the structure of the page and can improve accessibility for users who rely on assistive technologies.

  Secondly, for the button, I'd suggest adding a cursor: pointer rule to indicate that it's clickable and changing the colors on hover to give users visual feedback. Here's some example code that you can use:

  button:hover {
  background-color: rgb(103, 67, 255);
  background: linear-gradient(180deg, rgba(103, 67, 255, 1) 34%, rgba(49, 44, 235, 1) 100%);
  transition: background-color ease-in-out .4s;
  cursor: pointer;
  }
  

  That's all I wanted to suggest! Overall, your project looks great, and you're doing an awesome job! 🔥

  Marked as helpful

  0