Design comparison
SolutionDesign
Solution retrospective
Hello, so this is my second component. It is not great but learned so much on it :) Thank you for any feedback it will help me to get better.
Community feedback
- @Shivraj-K09Posted over 1 year ago
- Use more explanatory class names. Instead of using generic names like
.showResult
or.memory
, try to use more descriptive and meaningful class names like.result-section
or.memory-score
. - Use
semantic HTML tags
. Semantically correct HTML structure makes the code easier to read, understand, and maintain. You can use tags like<header>
,<section>
,<article>
,<nav>
,<main>
, etc. - Use consistent indentation and formatting style throughout the codebase. Consistency is key to improve code readability and maintainability.
- Consider using
BEM methodology
to name your classes.BEM
is a naming convention that makes it easier to understand the relationships and dependencies between different CSS classes. - Add more comments in the code, especially for complex or hard-to-understand sections. This will make it easier for other developers to understand the code and modify it if necessary.
Marked as helpful0 - Use more explanatory class names. Instead of using generic names like
- @Tiyana19Posted over 1 year ago
hey, you did a great job, here are some suggestions
attribution
is sticking with the card so give itposition: absolute
andbottom: 0
. and put theborder: none
value to thebutton
.0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord