Results summary component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 1 year ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  • You should use an alt attribute empty for the icons when they are used decoratively. This practice avoids the reading of the description by screen readers, which can be bothersome for users with visual impairments.

    However, it's important to note that if the element were not decorative, you should describe the image in the alt attribute rather than using a placeholder like "#".

  • Use min-height: 100vh instead of height. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.

  • Avoid using viewport units (e.g., vw and vh) for widths and heights, as they can lead to distortion on smaller screens. Test your solution, especially with devices in landscape orientation, where using vh for width might cause distortion.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  0

  ---

  

  Youssef Nachat•140

  @yousefnachatPosted about 1 year ago

  @MelvinAguilar thank you so much for you feedback it was helpfull

  0