Results summary component

Community feedback

• 

  Andrés Gutiérrez Ramírez•2,470

  @AGutierrezRPosted 11 months ago

  Hello there 👋. Good job on completing the challenge!

  I have some suggestions about your code that might interest you.

  General Structure and HTML:

  • Wrap the primary content within the <main> tag instead of using it as a standalone component like a <div>.
  • All the content should be contained within landmarks. Every page minimally needs a <main> element.
  • Consider using <ul> instead of multiple div for the summary items.

  CSS and Styling:

  • Implement CSS custom properties to define and utilize project colors more easily.
  • Instead of fixed widths, employ max-width and min-width for flexible and responsive design.
  • Let the content decide the height of the elements. Use padding and margins strategically for this purpose.
  • The body should not have its height limited. Instead of using height: 100vh, use min-height.

  I hope you find this helpful 😁. Most importantly, your submitted solution is fantastic!

  Happy coding!

  Marked as helpful

  1

  ---

  

  P

  Nick•260

  @nn-code80Posted 11 months ago

  Hi Andres. Thank you very much for your feedback. I appreciate it!! @AGutierrezR

  0