Design comparison
SolutionDesign
Solution retrospective
This is my first Tailwindcss project. I am open for any feedback especially for tailwind css
.
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
COMPONENT MEASUREMENTS π:
- The
h-screen
utility class is used to defineheight: 100vh
, But we want to usemin-height: 100vh
formain
instead ofheight: 100vh
. Setting theheight: 100vh
may result in the component being cut off on smaller screens.
- For example; if we set
height: 100vh
then themain
will have100vh
height no matter what. Even if the content spans more than100vh
.
- But if we set
min-height: 100vh
then themain
will start at100vh
, if the content pushes themain
beyond100vh
it will continue growing. However if you have content that takes less than100vh
it will still take100vh
in space.
- So we want to use
min-h-screen
utility class to definemin-height: 100vh
along with responsive utility you can add the class likemd:min-h-screen
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1@Mike-DavePosted over 1 year ago@0xAbdulKhalid Thank you so much. I really do appreciate. Happy Coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord