Design comparison
SolutionDesign
Community feedback
- @AGutierrezRPosted 11 months ago
Hello there 👋. Good job on completing the challenge!
I have some suggestions about your code that might interest you.
General Structure and HTML:
- Wrap the primary content within the
<main>
tag instead of using it as a standalone component like a<div>
. - All the content should be contained within landmarks. Every page minimally needs a
<main>
element.
CSS and Styling:
- The
body
should not have itsheight
limited. Instead of using.h-screen
on the body, use.min-h-screen
. - Apply a
max-w-[560px]
and alg:max-w-[736px]
to the card to prevent it from streching to much. - Let the content decide the height of the elements. Use padding and margins strategically for this purpose.
Accessibility and Semantic HTML:
- The icons images are decorative, so their alt text must be empty:
alt=""
.
I hope you find this helpful 😁. Most importantly, your submitted solution is fantastic!
Happy coding!
0@jesutobi-worldPosted 11 months agoThank you for the detailed suggestions. I'll make sure to do some adjustments as well as make use of the concepts in my next projects. @AGutierrezR
0 - Wrap the primary content within the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord