Design comparison
SolutionDesign
Solution retrospective
First project from site. This is a test to understand my knowledge about html and css basics world.
Community feedback
- @DXXDLYPosted over 1 year ago
Hey!
Great solution
1.It is generally recommended to include scripts at the bottom of an HTML document, before the closing </body> tag. This is done so that the browser can first load the content of the page before loading and executing the scripts.
2-3.Use the same units of measure. Specify font-size in em.
4.Use for of instead of foreach
for (const currentItem of data) { const summaryElement = document.getElementById(currentItem.category); const summaryResultElement = summaryElement.querySelector('.result-number'); const summaryImageElement = summaryElement.querySelector('.result-typo .icon'); summaryResultElement.textContent = currentItem.score; summaryImageElement.src = currentItem.icon; }
Good luck! I hope I helped you
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord