Results Component Template Solution - No Frameworks
Design comparison
Solution retrospective
Here is my solution for the Results Component challenge. I spent a little more time on it than I wanted to but I am proud of the end result. My biggest opportunity that is staring me in the face is writing excess code. I know that there is easier/cleaner ways to write/create what I have and that is the feedback I am seeking. Thanks everyone.
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML 🏷️:
- This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to
non-semanticmarkup, which lack landmark for a webpage
- So fix it by replacing the
<div class="container">element with the semantic element<main>in yourindex.htmlfile to improve accessibility and organization of your page.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>or<span>
- They convey the structure of your page. For example, the
<main>element should include all content directly related to the page's main idea, so there should only be one per page
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1@OpenWorldProjectOWPPosted over 1 year ago@0xAbdulKhalid yeah that's great man! Appreciate the tip!
0 - @OpenWorldProjectOWPPosted over 1 year ago
Updated landmarks recently. Thanks for the feedback again!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord