Design comparison
SolutionDesign
Solution retrospective
Would anyone help me modify this code for the mobile design given in challenge?
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
CSS π¨:
- Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using
margin
orpadding
.
- We don't need to use
margin
andpadding
to center the component both horizontally & vertically. Because usingmargin
orpadding
will not dynamical centers our component at all states
- To properly center the component in the page, you should use
Flexbox
orGrid
layout. You can read more about centering in CSS here π.
- For this demonstration we use css
Grid
to center the component.
body { min-height: 100vh; display: grid; place-items: center; }
- Now remove these styles, after removing you can able to see the changes
.row { flex-direction: row; } #left { margin-left: 500px; margin-top: 160px; position: absolute; } #right { margin-right: 30px; position: relative; margin-left: 740px; margin-top: 160px; }
- Now your component has been properly centered
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1@vivek33upPosted over 1 year ago@0xAbdulKhalid Thankyou so much!! It was really helpful. I had one question, so when I was trying to add a background color to my body, it didn't work. Was it because of using padding and margin to center the components?
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord