Andrés Gutiérrez Ramírez• 2,470
@AGutierrezR
Posted
Hello there @nachospreafico 👋. Good job on completing the challenge!
I have some suggestions about your code that might interest you.
General Structure and HTML:
- Wrap the primary content within the
<main>
tag instead of using it as a standalone component like a<div>
. - All the content should be contained within landmarks. Every page minimally needs a
<main>
element.
CSS and Styling:
- Avoid using
px
forfont-size
, you could read this article to learn why. Letter spacing and line height must not be inpx
, userem
for all the font-related properties. You could transform thetext-[Npx]
in atext-[Nrem]
instead
I hope you find this helpful 😁. Most importantly, your submitted solution is fantastic!
Happy coding!
0