Result-Page-Challenge

Community feedback

• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="container"> element with the proper semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  chanchala-amar•160

  @chanchala-amarPosted over 1 year ago

  Hello,

  Congragulations on completing this challenge. Here are some things that I could think of looking at your code

  1. Use semantic html instead of divs (https://www.semrush.com/blog/semantic-html5-guide/) and use alt in image tag to describe images - these two are needed for screen readers to read the page.
  2. Self explanatory naming CSS classes like .results-box{} and summary-box in place of fbox{} and lbox{}
  3. A small tweak in your code will solve the spacing of icon, icon name and score issue. So, instead of

  <div class="box-three">
            <div class="icon">
              <img src="./assets/images/icon-verbal.svg" alt="">
            </div>
            <div class="name">Verbal</div>
            <div class="num"><span class="bold">
              61 </span>/ 100</div>
          </div>
  

  try this,

  .icon{
    padding-right:5%;
  }
  .label{
    vertical-align:center;
  }
  
  <div class="box-three">
            <div class="icon">
              <img src="./assets/images/icon-verbal.svg" alt="verbal">
              <span class="label"> Verbal </span>
            </div>
           
            <div class="num"><span class="bold">
              61 </span>/ 100
           </div>
  </div>
  

  Good work -I liked your solution, best wishes for the next challenges!

  Marked as helpful

  0
• 

  Luis Alejandro Grajales•150

  @alejoxPosted over 1 year ago

  It's very good, just check what may be happening with the sources

  0

  ---

  

  Musyoka Sila•240

  @sila254Posted over 1 year ago

  @alejox Thanks .

  0