Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Result Summay Card using flex and grid

@pratikkw

Desktop design screenshot for the Results summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Please See my code and review it. Also see live site.

Community feedback

Abdul Khaliq πŸš€β€’ 72,660

@0xabdulkhaliq

Posted

Hello there πŸ‘‹. Congratulations on successfully completing the challenge! πŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

DECORATIVE SVG'S ♨️:

  • The alt attribute is used to provide alternative text for images in HTML documents. The alt attribute is used by screen readers to describe the image to visually impaired users, which is essential for web accessibility.
  • Now, when it comes to decorative SVGs, they are used purely for aesthetic purposes and do not convey any important information or functionality to the user.
  • Since these images do not convey any important information or functionality, there is no need for an alt attribute.
  • So feel free to set the alt attribute as "" for decorative svg's, because alt="" will be skipped by screen readers they will consider the image as decoration

Example:

<img src="images/decorative.svg" alt="">

<img src="assets/images/icon-reaction.svg" alt="Reaction" />
πŸ‘‡
<img src="assets/images/icon-reaction.svg" alt="" />

.

I hope you find this helpful πŸ˜„ Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

1

@pratikkw

Posted

@0xAbdulKhalid Thank you bro. Next time i will remember not to use alt for decorative svg.

0
Aimal Khanβ€’ 2,260

@Aimal-125

Posted

Bro i downloaded your code, and checked it and applied padding: 2rem; on body element in your CSS code and now the card is looking great on landscape mode of mobiles with screens with small heights.

@media only screen and (min-width: 37.5rem) {
body {
display: grid;
place-content: center;
padding: 2rem;
}

this is the code which i modified at the end of style.css file.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord