Skip to content
Submitted over 1 year ago

Result Summary using html and css

Praise-A•20
@Praise-A
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Results summary component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I had some difficulties making an accurate representation of the design.

Community feedback

  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    HTML 🏷️:

    • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage
    • So fix it by replacing the <section class="result-container"> element with the semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page.
    • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>
    • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

    HEADINGS ⚠️:

    • And, this solution has also generated accessibility error report due to lack of level-one heading <h1>
    • Every site must want at least one h1 element identifying and describing the main content of the page.
    • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
    • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

    CSS 🎨:

    • let me explain, How you can easily center the component.
    • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states
    • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.
    • For this demonstration we use css Grid to center the component
    body {
    min-height: 100vh;
    display: grid;
    place-items: center;

    margin: 0;
}
    • Now remove these styles, after removing you can able to see the changes
    .result-container {
  margin-left: 28%;
  margin-right: 28%;
  margin-top: 9%;
  margin-bottom: 9%;
}

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
    0
    Praise-A•20
    @Praise-APosted over 1 year ago

    @0xAbdulKhalid Thank you.

    0
  • C H A R A N 🎯•2,670
    @0xabdulPosted over 1 year ago

    Hello there well congrats on completing the Results summary component🤩

    • A Little bit suggestions for improve your code
    • In Html 🏷️ :
    • Heading ⚙️ :
    • in fact using the header tag line by line or sequence way
    • Ex :
    <h1> Your results </h1>
<h2> Great </h2>
<p> 
You scored higher than 65% 
of the people who have
 taken these tests.
</p>
    • The Main landmark⚠️
    • th html page should be contained one main landmark so fix them
    • to clear the Accessibility reports using semantic elements or non semantic elements
    • for easy way to clear the all Accessibility reports using non - semantic elements Ex : <div> , <span>
    • let's try
    • Ex :
    <body>
<div class="container" role="main">
//Html code here 🏷️
</div>
</body>
    • OR
    • using semantic elements Ex : <aside> <section> <main> <nav> <header> < footer>
    • Ex :
    <body>
        <header>company logo header name...</header>
        <main> the main content here</main>
        <footer>@Copy right Here</footer>
    </body>
</html>
    • In Css 🎨 :
    • your results summary card component is not center aligning so fix them
    body {
display:flex;
align-items:center;
justify-content:center;
height:100vh;
max-width:100%;
}
    • I Hope you find the solution and it's useful for you 😀
    • Happy CodingPraise-A
    Marked as helpful
    0
    Praise-A•20
    @Praise-APosted over 1 year ago

    @0xAbdul Thank you.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord