Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Result Summary Desktop-first solution using Flexbox

@emjayruka

Desktop design screenshot for the Results summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I think I made use of a lot of <div> Is there an alternative tag to use? And also, my CSS has more than 160 lines, which seems excessive. Is there a better practice? Any other feedback will really be appreciated.

Community feedback

Daniel 🛸 44,190

@danielmrz-dev

Posted

Hello @emjayruka!

Your solution looks great!

I have a couple of suggestions for improvement:

  • First: For semantic reasons, and since your page doesn't have a h1 heading you can replace the first <h2> with <h1>.

The <h1> to <h6> tags are used to define HTML headings. <h1> defines the most important heading. <h6> defines the least important heading. Only use one <h1> per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with <h1>, then use <h2>, and so on.

  • Second: Still about semantic HTML and your use of divs, you can replace your div.container with main.container. Using divs for smaller elements with low or no semantic value is ok. But for elements that are part of the sctructure of the page, we have better tags.

All these changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

I hope it helps!

Other than that, great job!

Marked as helpful

0

Account Deleted

Yo nice work ! I would say you need to make it responsive for mobile .. mobile version are a one column layout so your summary container would go under your result container and you can achieve that using a media querie with flex-direction: column then as you expand to desktop it will turn into flex-direction: row. Hope this help

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord