Design comparison
Solution retrospective
Solution for the results-summary. Advice and correction are most welcome.
Community feedback
- @RodrigoHLCPosted about 1 year ago
Like Eduardo mentioned, the problem is in the image path. When you were working on your computer, the path to the image file you used included going into the folder called "images". However, you did not upload the "assets" and "images" folder to your repository, so the src attributes link to folders that aren't there. You need to either:
change src="/assets/images..." to the top level src="./... or create the necessary folders on your repository and put the image files there, so that the path links to an existing location with your repository
PS: to my knowledge, you can't simply create a folder in github: you need to click on "New file" (or "Add file", don't remember exactly right now. Something like that), then when you have the option of typing the name of a file, press / which will create a new folder. Create a new, random file within this folder, and then rename the folder (if my explanation isn't clear, you can look up tutorials on YouTube, which is what I did, as I was going nuts trying to find a "Create folder" button).
Marked as helpful0@MogulZmPosted about 1 year ago@RodrigoHLC Thank you so much for the feedback, I will definitely do better in the next challenge.
1 - @EduardoLimaCastroPosted about 1 year ago
Hi Mumbi, think you forgot to put your assets/images folders in your github repository. Images are breaking on the live site.
Marked as helpful0@MogulZmPosted about 1 year ago@EduardoLimaCastro You are right and thank you for the feedback. I will do better on my next challenge.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord