@Thodoris-Diamantidis
Posted
Congratulations on completing the challenge!
To enhance your solution further, I recommend exploring the possibility of obtaining the data from a JSON file instead of hardcoding it. This approach can make your application more flexible and maintainable by separating data from code.
Additionally, it's a good practice to thoroughly test your calculations by experimenting with various input values to ensure the accuracy and reliability of the result scores. This will help you identify and address any potential edge cases or issues in your implementation.
I would advise against using font-size: 62.5% as it can potentially lead to compatibility issues with third-party packages and pose significant migration challenges. If you're interested in exploring the topics of sizing and accessibility further, I recommend reading Josh W. Comeau's article, which provides valuable insights.
If you found this feedback helpfull , please feal free to upvote :)
Marked as helpful
@FerdinandoGeografo
Posted
@Thodoris-Diamantidis Thanks for these very useful tips, regarding the use of data from the json file it was my choice because I wanted to focus more only on the style and on trying the approach of developing with the help of figma files.
@Thodoris-Diamantidis
Posted
@FerdinandoGeografo, I completely understand your reasons for using hardcoded data, especially if it aligns with your focus on styling and your approach to development with Figma files. It's essential to strike a balance between best practices and project-specific considerations.
I'm glad you found the tips helpful. Best of luck with your development work.
