Result Summary Component with Hover Component

Community feedback

• 

  Aravindhan•320

  @aravindhan7Posted about 1 year ago

  1. Actually you should use semantic tags to make it more accessible

  Examples of non-semantic elements: <div> and <span> - Tells nothing about its content. Examples of semantic elements: <form>, <table>, and <article> - Clearly defines its content.

  2.Yes the solution is pretty responsive

  3.code is organised well and easy to read. kindly go thru the BEM resource https://css-tricks.com/bem-101/

  4.The layout is good and the solution is awesome.Kudos

  Marked as helpful

  1

  ---

  

  Rohmat Setiawan•60

  @rohmatsetiawanmtaPosted about 1 year ago

  @aravindhan7 Hello.. Thank you for your comprehensive feedback. It's very helpful for me. I will take note for your suggestion on. Your advice will guide me in addressing next challenges. Thanks once more!

  0
• 

  Leonardo Mancilha Machado•100

  @LeonardoMancilhaPosted about 1 year ago

  Hello @rohmatsetiawanmta. I hope you're fine.

  You must use semantic tags to make it more accessible.

  Your code is organized well and easy to read, but your layout is not responsive when it comes to size 750px due to:

  1- You remove the width 100vw on line 50:

  .app { background: var(--very-light-blue); height: 100vh; display: flex; justify-content: center; align-items: center; }

  2- You remove the display block and put height auto on line 200:

  @media screen and (max-width: 750px) { .app { background: white; height: auto; } }

  With these changes, your website is responsive for any screen.

  Marked as helpful

  0

  ---

  

  Rohmat Setiawan•60

  @rohmatsetiawanmtaPosted about 1 year ago

  @LeonardoMancilha Hello.. Thank you for your feedback. For the semantic tags, I will note it down for the next challenge.

  Then, I did not see any changes regarding the responsiveness for the 2 points mentioned. However, I will note it down as another alternative if I encounter a similar thing in the future.

  Once again, thank you for the feedback you provided. You are so nice!

  0