@danielmrz-dev
Posted
Hello there!
Congrats on completing the challenge! โ
Your solution looks great!
I have a suggestion:
- Since you set grid to the body, but you didn't set the size of the rows, your footer is pushing your card up a little bit. You can prevent that from happening adding this to the body:
grid-template-rows: 90% 1fr;
Then your card will always occupy 90% of the space and the footer will adapt in the remaining space.
Also, you mistyped min-height: 100vh
, once you correct it, your card will be centered.
I hope it helps!
Other than that, you did an excellent job!
@CreativeLogic
Posted
@danielmrz-dev
I always had this issue and stopped using attribution because of it.
Is there a similar solution when using flex on the body instead of grid?
Also wouldn't this make it so it's not perfectly centered since it is centered only within 90% of the space? What's the solution to have an attribution and have it perfectly centered.