@rohitd99
Posted
Hi Phyu Sin Lin
Congrats on completing the challenge.
I think you've forgotten to change the border-radius
property on mobile view for the container-one and you also need to remove the box-shadow
property from the container class for mobile view. Also instead of having a section
you can just have the main
in this case since that is the only content on the page. As for the headings I think you've used the h2
and h3
for it's font sizes but headings have a meaning and shouldn't be used that way. Also for every page we need a single h1
element and all pages must have headings only from h1
through h6
that is first h1
then h2
and so on ,not any other way for semantics and SEO. So I'd use the h1
for the Result and h2
for others such as 'Great' and 'Summary'.
Also instead of having a bunch of media queries with width
in percentages , have a max-width : 52rem;
or some size and add a padding so as to not cover entire width on tablet sizes. Those media queries made your container-2
collapse and become very small for tablet sizes.
Hope it helped
Marked as helpful
@oliviaphyu
Posted
@rohitd99 Thanks for pointing out my mistakes. I have no idea how to make container-two collapse until you mention max-width.