Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Result summary component

@mayank1352002

Desktop design screenshot for the Results summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Pavel B. 270

@Jagholin

Posted

Container width as a % of viewport width looks and feels strange. It's better to just use some fixed values for min-width and/or max-width.

The same goes for height, only in this case it's better not to assign any value to height, the default in most cases is appropriate. If you try to change the size of the viewport, you'll see the problem.

(looking deeper, there are a lot of percentage-based heights and widths. I suggest removing them all unless necessary. Since you are using flexbox for many things, you should allow flex containers to decide appropriate widths/heights.)

Marked as helpful

0

@mayank1352002

Posted

@Jagholin thanks for the feedback. will try to impliment the required changes.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord