Pappyjay• 170
@Manifoldbit
Posted
Hi guys, Please kindly help me look into my code, I don't know why my solution is not in the same size as the design given, I would appreciate your feedback
0
Design comparison
Solution retrospective
Hi guys, Please I will love if you can help look into this code and show me how to use local JSON data to dynamically populate the content. Your feedbacks means alot to me. Thanks
Community feedback
Daniel 🛸• 44,230
@danielmrz-dev
Posted
Hello @Manifoldbit!
Your solution looks excelent!
I have just one suggestion:
- In order to make your HTML code more semantic, don't skip heading levels - start with
<h1>, then use<h2>, and so on. Unlike what most people think, it's not just about the size and weight of the text.
📌 The <h1> to <h6> tags are used to define HTML headings.
📌 <h1> defines the most important heading.
📌 <h6> defines the least important heading.
📌 Only use one <h1> per page - this should represent the main heading/title for the whole page.
This change has little or not effect at all on the project, but it makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, you did a great job!
0
Pappyjay• 170
@Manifoldbit
Posted
Please I will love if you can point out where I skipped heading levels, I started with h1 and then h2, I will appreciate if you can point out my mistakes @danielmrz-dev
1
Daniel 🛸• 44,230
@danielmrz-dev
Posted
@Manifoldbit
You're right, you didn't skip the levels. I didn't noticed that you used <h1> for the 76 number the fisrt time I checked your code.
Sorry 😅
0
Pappyjay• 170
@Manifoldbit
Posted
It's fine, can you help me fish out the error, I don't know why my solution doesn't match the given design @danielmrz-dev
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord