Design comparison
Solution retrospective
-I couldn't figure out how to add those little lines to the edge of the borders, for the blocks on the summary side
Community feedback
- @BenjaminSemahPosted about 1 year ago
Hi Mbungai. Great job done! 👍
HTML: For your HTML, I will encourage you to consider using semantic HTML elements. Divs are useful, but for the sake of accessibility, SEO, and improving code readability, using these semantic elements like main, section, footer, button, ul and li (for list items) is highly recommended.
CSS: Your CSS looks good! The only feedback I will give is on where you use
blocks:nth-child
. For example, you do this for all 4 blocks..blocks:nth-child(1) { background-color: #FFF6F5; } .blocks:nth-child(1) { color: hsl(0, 100%, 67%) }
Since it’s targeting the same element. You can do the following instead. This does the same thing and it’s more concise. And same for the other three
.block
elements too..blocks:nth-child(1) { background-color: #FFF6F5; color: hsl(0, 100%, 67%); }
Cheers and happy coding!
Marked as helpful0@Mbungai-FrancescoPosted about 1 year agoThanks for the proposals Sir, I'll do more research on semantic HTML elements and look at integrating them in my coding journey @BenjaminSemah
0 - @Zy8712Posted about 1 year ago
Your site looks pretty good. Not really too sure what you mean by "those little lines". I'm assuming you are refering to the box shadow of the container. In that case you can use the
box-shadow
css property to assign it to your div containing everything. You can read more about it here.Aside from that the only other thing I think could add is
<main>
tags to wrap around your content. This is different from your<div class="main">
.Hope this feedback is useful to you
0@Mbungai-FrancescoPosted about 1 year ago@Zy8712 If you zoom on the edges of the reaction tab or the memory tab and the 2 others, you'll notice some little lines on the four corners. That's what am talking about. " On the challenge it self, not on my solution"
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord