Result summary challenge solution by walkwithrahul
Design comparison
Solution retrospective
hello everyone , this is my first project solution on frontendmentor.io
i build this project using react and vite , i didn't face any major problems but i'm not so sure about best practices for system design with css.
i learned so much while building this project. thank you so much for this project.
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML π·οΈ:
- This solution generates accessibility error reports due to incorrect usage of
semantic
markup, which confueses landmark for a webpage
- So fix it by wrapping the whole content with semantic element
<main>
in yourindex.html
file to improve accessibility and organization of your page.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>
or<span>
- They convey the structure of your page. For example, the
<main>
element should include all content directly related to the page's main idea, so there should only be one per page
HEADINGS β οΈ:
- And, this solution had generated accessibility error report due to lack of level-one heading
<h1>
- Every site must want at least one
h1
element identifying and describing the main content of the page.
- An
h1
heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
- So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a
sr-only
class to hide it from visual users (it will be useful for visually impaired users)
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
0@WalkwithrahulPosted over 1 year ago@0xAbdulKhalid thank you so much for your valuable feedback.
i will try to improve accessibility of this website π
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord